fix(core): Fix broken e2e test after master merge - #4399
Merged
Conversation
The multi-channel productInStock cache test block was using old-style GraphQL constants (CREATE_CHANNEL, CREATE_PRODUCT, etc.) that were removed when master migrated to gql.tada document imports. The auto-merge didn't detect this semantic conflict since the test was in a new describe block touching different lines.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fix admonition syntax in PasswordHashingStrategy JSDoc (:::info Config → :::info[Config]) and remove backticks from inline JSDoc comments in PageActionBarRight props that break MDX template literal parsing.
The ES client was upgraded to 9.1.0 but only the sqljs e2e job was updated to match. The postgres, mysql and mariadb jobs still used ES 7.1.1 which rejects the v9 Content-Type header with a 406 error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterintominorcaused semantic conflicts in two e2e test filesmulti-channel productInStock cachetest blocks (added onminor) still referenced old-style GraphQL constants (CREATE_CHANNEL,CREATE_PRODUCT,REINDEX, etc.) that were removed whenmastermigrated to gql.tada document importsdescribesections, but at runtime the old constants are undefined, causingReferenceError: CREATE_CHANNEL is not definedpackages/core/e2e/default-search-plugin.e2e-spec.tspackages/elasticsearch-plugin/e2e/elasticsearch-plugin.e2e-spec.tsTest plan
default-search-plugin.e2e-spec.tsmulti-channel productInStock cache tests should run withoutReferenceErrorelasticsearch-plugin.e2e-spec.tsmulti-channel productInStock cache tests should run withoutReferenceError